fix(cli): update CLI and tests for server default parameters #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubcio
changed the title
hubcio
force-pushed
the
message-expiry-server-default
branch
from
30fbc44 to
4bab151
Compare
spetz
previously approved these changes
Feb 17, 2025
hubcio
force-pushed
the
message-expiry-server-default
branch
from
4bab151 to
0b08b16
Compare
BartoszCiesla
approved these changes
Feb 17, 2025
This commit updates the CLI and associated tests to use "server_default" as the default value for max topic size and message expiry time, instead of "unlimited". This change ensures that the CLI uses the server's default configuration when parameters are not explicitly specified by the user. Additionally, the commit modifies the display and parsing logic for `IggyExpiry` to use "never_expire" instead of "none" for clarity. The tests have been updated to reflect these changes, ensuring that the new defaults are correctly applied and tested. This closes #1536.
hubcio
force-pushed
the
message-expiry-server-default
branch
from
0b08b16 to
9dcd13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the CLI and associated tests to use "server_default"
as the default value for max topic size and message expiry time, instead
of "unlimited". This change ensures that the CLI uses the server's
default configuration when parameters are not explicitly specified by
the user. Additionally, the commit modifies the display and parsing
logic for
IggyExpiryto use "never_expire" instead of "none" forclarity. The tests have been updated to reflect these changes, ensuring
that the new defaults are correctly applied and tested.
This closes #1536.